Skip to content

Fix standard_form #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix standard_form #291

wants to merge 1 commit into from

Conversation

joaquimg
Copy link
Member

@blegat is this (part of) the solution for #283 ?

Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.20%. Comparing base (bf2c4c3) to head (2ce98f3).

Files with missing lines Patch % Lines
src/utils.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #291   +/-   ##
=======================================
  Coverage   89.20%   89.20%           
=======================================
  Files          15       15           
  Lines        1973     1973           
=======================================
  Hits         1760     1760           
  Misses        213      213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joaquimg
Copy link
Member Author

JuMP.coefficient does not go well with vector affine functions because in the JuMP level they are a Vector of AffExpr, hence there is no JuMP.coefficient(::SomeFunction, ::Integer, ::VariableRef).
Possibly the more JuMP-like API is allowing getindex to add a lazy layer on top of MatrixVectorAffineFunction, but that might be too complex to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant